Repository navigation
[tests] Port cppia client tests to utest - #1440
Merged
Merged
Conversation
The custom control flow handling with Common.status was getting unwieldy and difficult to understand/maintain. TestCommon was already using utest for host side checks. Now the client side checks are also using utest Asserts. The TestCommon related code is now also separated more clearly from the general client side test cases.
There is no reason to have this on the host anymore. The important part (calling .addValue) was already happening on the client.
These used to throw Null Reference errors. If a regression was to occur, they should be caught rather than causing the entire test suite to error out.
For some reason, running these checks in instance methods caused the original problems to be obscured when reintroducing the bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom control flow handling with Common.status was getting unwieldy
and difficult to understand/maintain. TestCommon was already using
utest for host side checks. Now the client side checks are also using
utest Asserts.
The TestCommon related code is now also separated more clearly from the
general client side test cases.